--- image.c 2004/01/30 18:53:50 1.26.2.14 +++ image.c 2004/04/12 15:49:56 1.29 @@ -3,7 +3,7 @@ * XVID MPEG-4 VIDEO CODEC * - Image management functions - * - * Copyright(C) 2001-2003 Peter Ross + * Copyright(C) 2001-2004 Peter Ross * * This program is free software ; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -19,7 +19,7 @@ * along with this program ; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * - * $Id: image.c,v 1.26.2.14 2004/01/30 18:53:50 chl Exp $ + * $Id: image.c,v 1.29 2004/04/12 15:49:56 edgomez Exp $ * ****************************************************************************/ @@ -35,6 +35,7 @@ #include "interpolate8x8.h" #include "reduced.h" #include "../utils/mem_align.h" +#include "../motion/sad.h" #include "font.h" /* XXX: remove later */ @@ -127,13 +128,16 @@ memcpy(image1->v, image2->v, edged_width * height / 4); } +/* setedges bug was fixed in this BS version */ +#define SETEDGES_BUG_BEFORE 18 void image_setedges(IMAGE * image, uint32_t edged_width, uint32_t edged_height, uint32_t width, - uint32_t height) + uint32_t height, + int bs_version) { const uint32_t edged_width2 = edged_width / 2; uint32_t width2; @@ -141,14 +145,16 @@ uint8_t *dst; uint8_t *src; - dst = image->y - (EDGE_SIZE + EDGE_SIZE * edged_width); src = image->y; /* According to the Standard Clause 7.6.4, padding is done starting at 16 - * pixel width and height multiples */ - width = (width+15)&~15; - height = (height+15)&~15; + * pixel width and height multiples. This was not respected in old xvids */ + if (bs_version == 0 || bs_version >= SETEDGES_BUG_BEFORE) { + width = (width+15)&~15; + height = (height+15)&~15; + } + width2 = width/2; for (i = 0; i < EDGE_SIZE; i++) { @@ -617,7 +623,7 @@ case XVID_CSP_YVYU: /* u/v swapped */ safe_packed_conv( - src[0], src_stride[0], image->y, image->v, image->y, + src[0], src_stride[0], image->y, image->v, image->u, edged_width, edged_width2, width, height, (csp & XVID_CSP_VFLIP), interlacing?yuyvi_to_yv12 :yuyv_to_yv12, interlacing?yuyvi_to_yv12_c:yuyv_to_yv12_c, 2); @@ -631,13 +637,13 @@ interlacing?uyvyi_to_yv12_c:uyvy_to_yv12_c, 2); break; - case XVID_CSP_YV12: /* YCrCb == internal colorspace for MPEG */ + case XVID_CSP_I420: /* YCbCr == YUV == internal colorspace for MPEG */ yv12_to_yv12(image->y, image->u, image->v, edged_width, edged_width2, src[0], src[0] + src_stride[0]*height, src[0] + src_stride[0]*height + (src_stride[0]/2)*height2, src_stride[0], src_stride[0]/2, width, height, (csp & XVID_CSP_VFLIP)); break; - case XVID_CSP_I420: /* YCbCr == U and V plane swapped */ + case XVID_CSP_YV12: /* YCrCb == YVA == U and V plane swapped */ yv12_to_yv12(image->y, image->v, image->u, edged_width, edged_width2, src[0], src[0] + src_stride[0]*height, src[0] + src_stride[0]*height + (src_stride[0]/2)*height2, src_stride[0], src_stride[0]/2, width, height, (csp & XVID_CSP_VFLIP)); @@ -807,14 +813,14 @@ interlacing?yv12_to_uyvyi_c:yv12_to_uyvy_c, 2); return 0; - case XVID_CSP_YV12: /* YCbCr == internal colorspace for MPEG */ + case XVID_CSP_I420: /* YCbCr == YUV == internal colorspace for MPEG */ yv12_to_yv12(dst[0], dst[0] + dst_stride[0]*height, dst[0] + dst_stride[0]*height + (dst_stride[0]/2)*height2, dst_stride[0], dst_stride[0]/2, image->y, image->u, image->v, edged_width, edged_width2, width, height, (csp & XVID_CSP_VFLIP)); return 0; - case XVID_CSP_I420: /* YCrCb == U and V plane swapped */ + case XVID_CSP_YV12: /* YCrCb == YVU == U and V plane swapped */ yv12_to_yv12(dst[0], dst[0] + dst_stride[0]*height, dst[0] + dst_stride[0]*height + (dst_stride[0]/2)*height2, dst_stride[0], dst_stride[0]/2, image->y, image->v, image->u, edged_width, edged_width2, @@ -888,24 +894,64 @@ } -long plane_sse(uint8_t * orig, - uint8_t * recon, - uint16_t stride, - uint16_t width, - uint16_t height) +long plane_sse(uint8_t *orig, + uint8_t *recon, + uint16_t stride, + uint16_t width, + uint16_t height) { - int diff, x, y; - long sse=0; + int y, bwidth, bheight; + long sse = 0; - for (y = 0; y < height; y++) { + bwidth = width & (~0x07); + bheight = height & (~0x07); + + /* Compute the 8x8 integer part */ + for (y = 0; y